[ROCm][Bugfix] Return empty UUID string when amdsmi uuid query fails#48708
Draft
ChuanLi1101 wants to merge 3 commits into
Draft
[ROCm][Bugfix] Return empty UUID string when amdsmi uuid query fails#48708ChuanLi1101 wants to merge 3 commits into
ChuanLi1101 wants to merge 3 commits into
Conversation
RocmPlatform.get_device_uuid caught AmdSmiException from amdsmi_get_gpu_device_uuid but did not return, leaving device_uuid unbound. The trailing `return device_uuid` then raised UnboundLocalError, masking the original amdsmi error. Return "" on failure, matching the handling of the preceding handle-query block. Signed-off-by: Chuan Li <chuali@amd.com> Co-authored-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocmPlatform.get_device_uuid caught AmdSmiException from amdsmi_get_gpu_device_uuid but did not return, leaving device_uuid unbound. The trailing
return device_uuidthen raised UnboundLocalError, masking the original amdsmi error. Return "" on failure, matching the handling of the preceding handle-query block.Co-authored-by: Cursor
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.